figured out better way using credential in 2.9 duh

roles/install_demo/tasks/azure_cred.yml

@@ -14,9 +14,7 @@
     tower_password: "{{ my_tower_password }}"
     tower_host: "{{ my_tower_host }}"
 
-- name: setting the new azure cred to cloud cred var
+
-  set_fact:
-   my_cloud_cred: azure_credential 
   
       
 

roles/install_demo/tasks/job_template.yml

@@ -42,9 +42,7 @@
     project: "{{ vars[demo].project.name }}"
     playbook: "{{ vars[demo].playbook }}"
     fact_caching_enabled: "{{ vars[demo].fact_caching_enabled | default('false') }}"
-    credential: "{{ my_cloud_cred | default(omit) }}"
+    credential: "{{ vars[demo].credential }}"
-      # use for regular playbooks "{{ vars[demo].credential }}"
-      
     survey_enabled: "{{ vars[demo].survey_enabled }}"
     survey_spec: "{{ vars[demo].survey_spec }}"
     tower_username: "{{ my_tower_username }}"

roles/install_demo/vars/main/infrastructure/azure_provision_vm.yml

@@ -8,7 +8,7 @@ azure_provision_vm:
   job_type: "run"
   inventory: "Workshop Inventory"
   playbook: "playbooks/infrastructure/azure_provision_vm.yml"
-  credential: "Workshop Credential"
+  credential: "azure_credential"
   survey_enabled: true
   survey_spec:
     name: Azure Provision VM