Random Bug fixes (#103)

Co-authored-by: youtous <contact@youtous.me>

.github/workflows/ansible-lint.yml

@@ -1,17 +0,0 @@
----
-name: Ansible Lint
-on:
- - push
- - pull_request_target
-
-env:
-  ANSIBLE_GALAXY_SERVER_AH_TOKEN: ${{ secrets.ANSIBLE_GALAXY_SERVER_AH_TOKEN }}
-
-jobs:
-  build:
-    name: Ansible Lint
-    runs-on: ubuntu-latest
-    steps:
-      # this action implicitly calls actions/checkout
-      - name: Run ansible-lint
-        uses: ansible/ansible-lint@v6.18.0

.github/workflows/linter.yml.old

@@ -1,50 +0,0 @@
----
-###########################
-###########################
-## Linter GitHub Actions ##
-###########################
-###########################
-name: Lint Code Base
-
-#
-# Documentation:
-# https://help.github.com/en/articles/workflow-syntax-for-github-actions
-#
-
-#############################
-# Start the job on all push #
-#############################
-on: [push, pull_request]
-
-###############
-# Set the Job #
-###############
-jobs:
-  build:
-    # Name the Job
-    name: Lint Code Base
-    # Set the agent to run on
-    runs-on: ubuntu-latest
-
-    ##################
-    # Load all steps #
-    ##################
-    steps:
-      ##########################
-      # Checkout the code base #
-      ##########################
-      - name: Checkout Code
-        uses: actions/checkout@v2
-        with:
-          # Full git history is needed to get a proper list of changed files within `super-linter`
-          fetch-depth: 0
-
-      ################################
-      # Run Linter against code base #
-      ################################
-      - name: Lint Code Base
-        uses: github/super-linter@v4
-        env:
-          VALIDATE_ALL_CODEBASE: false
-          DEFAULT_BRANCH: main
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/pre-commit.yml

@@ -0,0 +1,17 @@
+---
+name: pre-commit
+on:
+ - push
+ - pull_request_target
+
+env:
+  ANSIBLE_GALAXY_SERVER_AH_TOKEN: ${{ secrets.ANSIBLE_GALAXY_SERVER_AH_TOKEN }}
+
+jobs:
+  pre-commit:
+    name: pre-commit
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - uses: actions/setup-python@v3
+    - uses: pre-commit/action@v3.0.0

.pre-commit-config.yaml

@@ -7,7 +7,7 @@ repos:
       - id: trailing-whitespace
   - repo: https://github.com/ansible/ansible-lint.git
     # get latest release tag from https://github.com/ansible/ansible-lint/releases/
-    rev: v6.18.0
+    rev: v6.20.3
     hooks:
       - id: ansible-lint
         additional_dependencies:

CONTRIBUTING.md

@@ -54,6 +54,21 @@ This document aims to outline the requirements for the various forms of contribu
 3) Include a README.md in the subdirectory
 
 ## Testing
-To run `ansible-lint` you will need to set an environment variable for the token to connect to Automation Hub. You can get a token from [here](https://console.redhat.com/ansible/automation-hub/token). 
 
-Copy the value of the token and run `export ANSIBLE_GALAXY_SERVER_AH_TOKEN=<token>`
+We utilize pre-commit to handle Git hooks, initiating a pre-commit check with each commit, both locally and on CI.
+
+To install pre-commit, use the following commands:
+```bash
+pip install pre-commit
+pre-commit install
+```
+
+For further details, refer to the [pre-commit installation documentation](https://pre-commit.com/#installation).
+
+To execute ansible-lint (whether within pre-commit or independently), you must configure an environment variable for the token required to connect to Automation Hub. Obtain the token [here](https://console.redhat.com/ansible/automation-hub/token).
+
+Copy the token value and execute the following command:
+
+```bash
+export ANSIBLE_GALAXY_SERVER_AH_TOKEN=<token>
+```

ansible.cfg

@@ -6,7 +6,9 @@ roles_path=./roles
 server_list = ah,galaxy
 
 [galaxy_server.ah]
-#url=https://cloud.redhat.com/api/automation-hub/
+# Grab a token at https://console.redhat.com/ansible/automation-hub/token
+# Then define it using ANSIBLE_GALAXY_SERVER_AH_TOKEN=""
+
 url=https://console.redhat.com/api/automation-hub/content/published/
 auth_url=https://sso.redhat.com/auth/realms/redhat-external/protocol/openid-connect/token
 

collections/ansible_collections/demo/patching/plugins/modules/scan_packages.py

@@ -2,15 +2,15 @@
 
 from ansible.module_utils.basic import *  # noqa
 
-DOCUMENTATION = '''
+DOCUMENTATION = """
 ---
 module: scan_packages
 short_description: Return installed packages information as fact data
 description:
     - Return information about installed packages as fact data
-'''
+"""
 
-EXAMPLES = '''
+EXAMPLES = """
 # Example fact output:
 # host | success >> {
 #    "ansible_facts": {
@@ -34,21 +34,23 @@ EXAMPLES = '''
 #                  "name": "gcc-4.8-base"
 #                }
 #       ]
-'''
+"""
 
 
 def rpm_package_list():
     import rpm
+
     trans_set = rpm.TransactionSet()
     installed_packages = []
     for package in trans_set.dbMatch():
         package_details = {
-                               'name':package[rpm.RPMTAG_NAME],
+            "name": package[rpm.RPMTAG_NAME],
-                               'version':package[rpm.RPMTAG_VERSION],
+            "version": package[rpm.RPMTAG_VERSION],
-                               'release':package[rpm.RPMTAG_RELEASE],
+            "release": package[rpm.RPMTAG_RELEASE],
-                               'epoch':package[rpm.RPMTAG_EPOCH],
+            "epoch": package[rpm.RPMTAG_EPOCH],
-                               'arch':package[rpm.RPMTAG_ARCH],
+            "arch": package[rpm.RPMTAG_ARCH],
-                               'source':'rpm' }
+            "source": "rpm",
+        }
         if installed_packages == []:
             installed_packages = [package_details]
         else:
@@ -58,16 +60,20 @@ def rpm_package_list():
 
 def deb_package_list():
     import apt
+
     apt_cache = apt.Cache()
     installed_packages = []
-    apt_installed_packages = [pk for pk in apt_cache.keys() if apt_cache[pk].is_installed]
+    apt_installed_packages = [
+        pk for pk in apt_cache.keys() if apt_cache[pk].is_installed
+    ]
     for package in apt_installed_packages:
         ac_pkg = apt_cache[package].installed
         package_details = {
-                               'name':package,
+            "name": package,
-                               'version':ac_pkg.version,
+            "version": ac_pkg.version,
-                               'arch':ac_pkg.architecture,
+            "arch": ac_pkg.architecture,
-                               'source':'apt'}
+            "source": "apt",
+        }
         if installed_packages == []:
             installed_packages = [package_details]
         else:
@@ -76,13 +82,11 @@ def deb_package_list():
 
 
 def main():
-    module = AnsibleModule(
+    module = AnsibleModule(argument_spec=dict(os_family=dict(required=True)))
-        argument_spec = dict(os_family=dict(required=True))
+    ans_os = module.params["os_family"]
-    )
+    if ans_os in ("RedHat", "Suse", "openSUSE Leap"):
-    ans_os = module.params['os_family']
-    if ans_os in ('RedHat', 'Suse', 'openSUSE Leap'):
         packages = rpm_package_list()
-    elif ans_os == 'Debian':
+    elif ans_os == "Debian":
         packages = deb_package_list()
     else:
         packages = None

collections/ansible_collections/demo/patching/plugins/modules/scan_services.py

@@ -3,16 +3,18 @@
 import re
 from ansible.module_utils.basic import *  # noqa
 
-DOCUMENTATION = '''
+DOCUMENTATION = """
 ---
 module: scan_services
 short_description: Return service state information as fact data
 description:
      - Return service state information as fact data for various service management utilities
-'''
+"""
 
-EXAMPLES = '''
+EXAMPLES = """
+---
 - monit: scan_services
+
 # Example fact output:
 # host | success >> {
 #   "ansible_facts": {
@@ -29,18 +31,17 @@ EXAMPLES = '''
 #       }
 #     }
 #   }
-'''
+# }
+"""
 
 
 class BaseService(object):
-
     def __init__(self, module):
         self.module = module
         self.incomplete_warning = False
 
 
 class ServiceScanService(BaseService):
-
     def gather_services(self):
         services = {}
         service_path = self.module.get_bin_path("service")
@@ -51,7 +52,10 @@ class ServiceScanService(BaseService):
 
         # sysvinit
         if service_path is not None and chkconfig_path is None:
-            rc, stdout, stderr = self.module.run_command("%s --status-all 2>&1 | grep -E \"\\[ (\\+|\\-) \\]\"" % service_path, use_unsafe_shell=True)
+            rc, stdout, stderr = self.module.run_command(
+                '%s --status-all 2>&1 | grep -E "\\[ (\\+|\\-) \\]"' % service_path,
+                use_unsafe_shell=True,
+            )
             for line in stdout.split("\n"):
                 line_data = line.split()
                 if len(line_data) < 4:
@@ -61,84 +65,112 @@ class ServiceScanService(BaseService):
                     service_state = "running"
                 else:
                     service_state = "stopped"
-                services[service_name] = {"name": service_name, "state": service_state, "source": "sysv"}
+                services[service_name] = {
+                    "name": service_name,
+                    "state": service_state,
+                    "source": "sysv",
+                }
 
         # Upstart
         if initctl_path is not None and chkconfig_path is None:
-            p = re.compile('^\s?(?P<name>.*)\s(?P<goal>\w+)\/(?P<state>\w+)(\,\sprocess\s(?P<pid>[0-9]+))?\s*$')
+            p = re.compile(
+                "^\s?(?P<name>.*)\s(?P<goal>\w+)\/(?P<state>\w+)(\,\sprocess\s(?P<pid>[0-9]+))?\s*$"
+            )
             rc, stdout, stderr = self.module.run_command("%s list" % initctl_path)
-            real_stdout = stdout.replace("\r","")
+            real_stdout = stdout.replace("\r", "")
             for line in real_stdout.split("\n"):
                 m = p.match(line)
                 if not m:
                     continue
-                service_name = m.group('name')
+                service_name = m.group("name")
-                service_goal = m.group('goal')
+                service_goal = m.group("goal")
-                service_state = m.group('state')
+                service_state = m.group("state")
-                if m.group('pid'):
+                if m.group("pid"):
-                    pid = m.group('pid')
+                    pid = m.group("pid")
                 else:
                     pid = None  # NOQA
-                payload = {"name": service_name, "state": service_state, "goal": service_goal, "source": "upstart"}
+                payload = {
+                    "name": service_name,
+                    "state": service_state,
+                    "goal": service_goal,
+                    "source": "upstart",
+                }
                 services[service_name] = payload
 
         # RH sysvinit
         elif chkconfig_path is not None:
-            #print '%s --status-all | grep -E "is (running|stopped)"' % service_path
+            # print '%s --status-all | grep -E "is (running|stopped)"' % service_path
             p = re.compile(
-                '(?P<service>.*?)\s+[0-9]:(?P<rl0>on|off)\s+[0-9]:(?P<rl1>on|off)\s+[0-9]:(?P<rl2>on|off)\s+'
+                "(?P<service>.*?)\s+[0-9]:(?P<rl0>on|off)\s+[0-9]:(?P<rl1>on|off)\s+[0-9]:(?P<rl2>on|off)\s+"
-                '[0-9]:(?P<rl3>on|off)\s+[0-9]:(?P<rl4>on|off)\s+[0-9]:(?P<rl5>on|off)\s+[0-9]:(?P<rl6>on|off)')
+                "[0-9]:(?P<rl3>on|off)\s+[0-9]:(?P<rl4>on|off)\s+[0-9]:(?P<rl5>on|off)\s+[0-9]:(?P<rl6>on|off)"
-            rc, stdout, stderr = self.module.run_command('%s' % chkconfig_path, use_unsafe_shell=True)
+            )
+            rc, stdout, stderr = self.module.run_command(
+                "%s" % chkconfig_path, use_unsafe_shell=True
+            )
             # Check for special cases where stdout does not fit pattern
             match_any = False
-            for line in stdout.split('\n'):
+            for line in stdout.split("\n"):
                 if p.match(line):
                     match_any = True
             if not match_any:
-                p_simple = re.compile('(?P<service>.*?)\s+(?P<rl0>on|off)')
+                p_simple = re.compile("(?P<service>.*?)\s+(?P<rl0>on|off)")
                 match_any = False
-                for line in stdout.split('\n'):
+                for line in stdout.split("\n"):
                     if p_simple.match(line):
                         match_any = True
                 if match_any:
                     # Try extra flags " -l --allservices" needed for SLES11
-                    rc, stdout, stderr = self.module.run_command('%s -l --allservices' % chkconfig_path, use_unsafe_shell=True)
+                    rc, stdout, stderr = self.module.run_command(
-                elif '--list' in stderr:
+                        "%s -l --allservices" % chkconfig_path, use_unsafe_shell=True
+                    )
+                elif "--list" in stderr:
                     # Extra flag needed for RHEL5
-                    rc, stdout, stderr = self.module.run_command('%s --list' % chkconfig_path, use_unsafe_shell=True)
+                    rc, stdout, stderr = self.module.run_command(
-            for line in stdout.split('\n'):
+                        "%s --list" % chkconfig_path, use_unsafe_shell=True
+                    )
+            for line in stdout.split("\n"):
                 m = p.match(line)
                 if m:
-                    service_name = m.group('service')
+                    service_name = m.group("service")
-                    service_state = 'stopped'
+                    service_state = "stopped"
-                    if m.group('rl3') == 'on':
+                    if m.group("rl3") == "on":
-                        rc, stdout, stderr = self.module.run_command('%s %s status' % (service_path, service_name), use_unsafe_shell=True)
+                        rc, stdout, stderr = self.module.run_command(
+                            "%s %s status" % (service_path, service_name),
+                            use_unsafe_shell=True,
+                        )
                         service_state = rc
                         if rc in (0,):
-                            service_state = 'running'
+                            service_state = "running"
-                        #elif rc in (1,3):
+                        # elif rc in (1,3):
                         else:
-                            if 'root' in stderr or 'permission' in stderr.lower() or 'not in sudoers' in stderr.lower():
+                            if (
+                                "root" in stderr
+                                or "permission" in stderr.lower()
+                                or "not in sudoers" in stderr.lower()
+                            ):
                                 self.incomplete_warning = True
                                 continue
                             else:
-                                service_state = 'stopped'
+                                service_state = "stopped"
-                    service_data = {"name": service_name, "state": service_state, "source": "sysv"}
+                    service_data = {
+                        "name": service_name,
+                        "state": service_state,
+                        "source": "sysv",
+                    }
                     services[service_name] = service_data
         return services
 
 
 class SystemctlScanService(BaseService):
-
     def systemd_enabled(self):
         # Check if init is the systemd command, using comm as cmdline could be symlink
         try:
-            f = open('/proc/1/comm', 'r')
+            f = open("/proc/1/comm", "r")
         except IOError:
             # If comm doesn't exist, old kernel, no systemd
             return False
         for line in f:
-            if 'systemd' in line:
+            if "systemd" in line:
                 return True
         return False
 
@@ -146,10 +178,16 @@ class SystemctlScanService(BaseService):
         services = {}
         if not self.systemd_enabled():
             return None
-        systemctl_path = self.module.get_bin_path("systemctl", opt_dirs=["/usr/bin", "/usr/local/bin"])
+        systemctl_path = self.module.get_bin_path(
+            "systemctl", opt_dirs=["/usr/bin", "/usr/local/bin"]
+        )
         if systemctl_path is None:
             return None
-        rc, stdout, stderr = self.module.run_command("%s list-unit-files --type=service | tail -n +2 | head -n -2" % systemctl_path, use_unsafe_shell=True)
+        rc, stdout, stderr = self.module.run_command(
+            "%s list-unit-files --type=service | tail -n +2 | head -n -2"
+            % systemctl_path,
+            use_unsafe_shell=True,
+        )
         for line in stdout.split("\n"):
             line_data = line.split()
             if len(line_data) != 2:
@@ -158,12 +196,16 @@ class SystemctlScanService(BaseService):
                 state_val = "running"
             else:
                 state_val = "stopped"
-            services[line_data[0]] = {"name": line_data[0], "state": state_val, "source": "systemd"}
+            services[line_data[0]] = {
+                "name": line_data[0],
+                "state": state_val,
+                "source": "systemd",
+            }
         return services
 
 
 def main():
-    module = AnsibleModule(argument_spec = dict())
+    module = AnsibleModule(argument_spec=dict())
     service_modules = (ServiceScanService, SystemctlScanService)
     all_services = {}
     incomplete_warning = False
@@ -175,11 +217,16 @@ def main():
             if svcmod.incomplete_warning:
                 incomplete_warning = True
     if len(all_services) == 0:
-        results = dict(skipped=True, msg="Failed to find any services. Sometimes this is due to insufficient privileges.")
+        results = dict(
+            skipped=True,
+            msg="Failed to find any services. Sometimes this is due to insufficient privileges.",
+        )
     else:
         results = dict(ansible_facts=dict(services=all_services))
         if incomplete_warning:
-            results['msg'] = "WARNING: Could not find status for all services. Sometimes this is due to insufficient privileges."
+            results[
+                "msg"
+            ] = "WARNING: Could not find status for all services. Sometimes this is due to insufficient privileges."
     module.exit_json(**results)
 
 

collections/ansible_collections/demo/patching/plugins/modules/win_scan_packages.py

@@ -1,31 +1,34 @@
-#!/usr/bin/env python
+!/usr/bin/env python
-# -*- coding: utf-8 -*-
+ -*- coding: utf-8 -*-
 
-DOCUMENTATION = '''
+DOCUMENTATION = """
 ---
 module: win_scan_packages
 short_description: Return Package state information as fact data
 description:
      - Return Package state information as fact data for various Packages
-'''
+"""
 
-EXAMPLES = '''
+EXAMPLES = """
 - monit: win_scan_packages
+
 #  Example fact output:
 #  host | success >> {
 #   "ansible_facts": {
 #     "packages": [
-            {
+#       {
-                "name": "Mozilla Firefox 76.0.1 (x64 en-US)",
+#         "name": "Mozilla Firefox 76.0.1 (x64 en-US)",
-                "version": "76.0.1",
+#         "version": "76.0.1",
-                "publisher": "Mozilla",
+#         "publisher": "Mozilla",
-                "arch": "Win64"
+#         "arch": "Win64"
-            },
+#       },
-            {
+#       {
-                "name": "Mozilla Maintenance Service",
+#         "name": "Mozilla Maintenance Service",
-                "version": "76.0.1",
+#         "version": "76.0.1",
-                "publisher": "Mozilla",
+#         "publisher": "Mozilla",
-                "arch": "Win64"
+#         "arch": "Win64"
-            },
 #       }
-'''
+#     ]
+#   }
+# }
+"""

collections/ansible_collections/demo/patching/plugins/modules/win_scan_services.py

@@ -1,34 +1,37 @@
 #!/usr/bin/env python
 # -*- coding: utf-8 -*-
 
-DOCUMENTATION = '''
+DOCUMENTATION = """
 ---
 module: win_scan_services
 short_description: Return service state information as fact data
 description:
      - Return service state information as fact data for various service management utilities
-'''
+"""
 
-EXAMPLES = '''
+EXAMPLES = """
 - monit: win_scan_services
+
 # Example fact output:
 # host | success >> {
 #   "ansible_facts": {
 #     "services": [
-            {
+#       {
-                "name": "AllJoyn Router Service",
+#         "name": "AllJoyn Router Service",
-                "win_svc_name": "AJRouter",
+#         "win_svc_name": "AJRouter",
-                "state": "stopped"
+#         "state": "stopped"
-            },
+#       },
-            {
+#       {
-                "name": "Application Layer Gateway Service",
+#         "name": "Application Layer Gateway Service",
-                "win_svc_name": "ALG",
+#         "win_svc_name": "ALG",
-                "state": "stopped"
+#         "state": "stopped"
-            },
+#       },
-            {
+#       {
-                "name": "Application Host Helper Service",
+#         "name": "Application Host Helper Service",
-                "win_svc_name": "AppHostSvc",
+#         "win_svc_name": "AppHostSvc",
-                "state": "running"
+#         "state": "running"
-            },
 #       }
-'''
+#     ]
+#   }
+# }
+"""

collections/ansible_collections/demo/patching/roles/build_report_network/vars/main.yml

@@ -1,12 +1,12 @@
 ---
-file_path: "{{ web_path | default('/var/www/html/reports') }}"
+file_path: "{{ web_path | default('/var/www/html/reports') }}"   # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-vendor:
+vendor:    # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
   ios: &my_value 'Cisco'
   nxos: *my_value
   iosxr: *my_value
   junos: "Juniper"
   eos: "Arista"
-transport:
+transport:    # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
   cliconf: "Network_CLI"
   netconf: "NETCONF"
   nxapi: "NX-API"

collections/ansible_collections/demo/patching/roles/build_report_windows/defaults/main.yml

@@ -1,2 +1,2 @@
 ---
-detailedreport: true
+detailedreport: true  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/build_report_windows/vars/main.yml

@@ -1,2 +1,2 @@
 ---
-file_path: /var/www/html
+file_path: /var/www/html  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/build_report_windows_patch/defaults/main.yml

@@ -1,4 +1,4 @@
 ---
-email_from: tower@shadowman.dev
+email_from: tower@shadowman.dev  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-to_emails: alex@shadowman.dev,tower@shadowman.dev
+to_emails: alex@shadowman.dev,tower@shadowman.dev  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-to_emails_list: "{{ to_emails.split(',') }}"
+to_emails_list: "{{ to_emails.split(',') }}"  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/build_report_windows_patch/vars/main.yml

@@ -1,2 +1,2 @@
 ---
-file_path: /var/www/html
+file_path: /var/www/html  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/patch_linux/defaults/main.yml

@@ -1,7 +1,7 @@
 ---
-exclude_packages:
+exclude_packages:  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
   - authselect
   - authselect-compat
   - authselect-libs
   - fprintd-pam
-allow_reboot: true
+allow_reboot: true  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/patch_windows/defaults/main.yml

@@ -1,5 +1,5 @@
 ---
-win_update_categories:
+win_update_categories:  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
   - Application
   - Connectors
   - CriticalUpdates
@@ -11,4 +11,4 @@ win_update_categories:
   - Tools
   - UpdateRollups
   - Updates
-allow_reboot: true
+allow_reboot: true  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/report_linux/defaults/main.yml

@@ -1,2 +1,2 @@
 ---
-detailedreport: true
+detailedreport: true  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/report_linux/vars/main.yml

@@ -1,2 +1,2 @@
 ---
-file_path: /var/www/html/reports
+file_path: /var/www/html/reports  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/report_linux_patching/defaults/main.yml

@@ -1,4 +1,4 @@
 ---
-email_from: tower@shadowman.dev
+email_from: tower@shadowman.dev  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-to_emails: alex@shadowman.dev,tower@shadowman.dev
+to_emails: alex@shadowman.dev,tower@shadowman.dev  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-to_emails_list: "{{ to_emails.split(',') }}"
+to_emails_list: "{{ to_emails.split(',') }}"  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/report_linux_patching/vars/main.yml

@@ -1,2 +1,2 @@
 ---
-file_path: /var/www/html/reports
+file_path: /var/www/html/reports  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/report_server/vars/Linux.yml

@@ -1,3 +1,3 @@
 ---
-doc_root: /var/www/html
+doc_root: /var/www/html  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-reports_dir: reports
+reports_dir: reports  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/report_server/vars/Win32NT.yml

@@ -1,3 +1,3 @@
 ---
-doc_root: C:\Inetpub\wwwroot
+doc_root: C:\Inetpub\wwwroot    # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-reports_dir: reports
+reports_dir: reports    # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/report_windows/defaults/main.yml

@@ -1,2 +1,2 @@
 ---
-detailedreport: true
+detailedreport: true    # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/report_windows/vars/main.yml

@@ -1,2 +1,2 @@
 ---
-file_path: C:\Inetpub\wwwroot\reports
+file_path: C:\Inetpub\wwwroot\reports    # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/report_windows_patching/defaults/main.yml

@@ -1,4 +1,4 @@
 ---
-email_from: tower@shadowman.dev
+email_from: tower@shadowman.dev  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-to_emails: alex@shadowman.dev,tower@shadowman.dev
+to_emails: alex@shadowman.dev,tower@shadowman.dev  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-to_emails_list: "{{ to_emails.split(',') }}"
+to_emails_list: "{{ to_emails.split(',') }}"  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/patching/roles/report_windows_patching/vars/main.yml

@@ -1,2 +1,2 @@
 ---
-file_path: C:\Inetpub\wwwroot\reports
+file_path: C:\Inetpub\wwwroot\reports  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/satellite/roles/register_host/defaults/main.yml

@@ -1,5 +1,5 @@
 ---
-instance_name: "{{ inventory_hostname | regex_replace('_', '-') }}"
+instance_name: "{{ inventory_hostname | regex_replace('_', '-') }}"    # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-activation_key: "{{ 'RHEL' + ansible_distribution_major_version + '_' + env }}"
+activation_key: "{{ 'RHEL' + ansible_distribution_major_version + '_' + env }}"    # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-rex_user: root  # "{{ ansible_user }}"
+rex_user: root  # "{{ ansible_user }}"  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-force_register: true
+force_register: true    # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

collections/ansible_collections/demo/satellite/roles/register_host/vars/RedHat7.yml

@@ -1,4 +1,4 @@
 ---
-rhsm_enabled_repos:
+rhsm_enabled_repos:  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
   - rhel-7-server-rpms
   # - rhel-7-server-satellite-maintenance-6.11-rpms

collections/ansible_collections/demo/satellite/roles/register_host/vars/RedHat8.yml

@@ -1,5 +1,5 @@
 ---
-rhsm_enabled_repos:
+rhsm_enabled_repos:  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
   - rhel-8-for-x86_64-baseos-rpms
   - rhel-8-for-x86_64-appstream-rpms
   - satellite-client-6-for-rhel-8-x86_64-rpms

collections/ansible_collections/demo/satellite/roles/scap_client/defaults/main.yaml

@@ -1,13 +1,13 @@
 ---
-foreman_server_url: "{{ lookup('env', 'SATELLITE_SERVER') }}"
+foreman_server_url: "{{ lookup('env', 'SATELLITE_SERVER') }}"   # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-foreman_username: "{{ lookup('env', 'SATELLITE_USERNAME') }}"
+foreman_username: "{{ lookup('env', 'SATELLITE_USERNAME') }}"   # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-foreman_password: "{{ lookup('env', 'SATELLITE_PASSWORD') }}"
+foreman_password: "{{ lookup('env', 'SATELLITE_PASSWORD') }}"   # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-foreman_validate_certs: "{{ lookup('env', 'FOREMAN_VALIDATE_CERTS') | default(true) }}"
+foreman_validate_certs: "{{ lookup('env', 'FOREMAN_VALIDATE_CERTS') | default(true) }}"   # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-capsule_server: "{{ foreman_server_url }}"
+capsule_server: "{{ foreman_server_url }}"   # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-capsule_port: '9090'
+capsule_port: '9090'   # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-policy_name: 'all'
+policy_name: 'all'   # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-policy_scan: "{{ policy_name }}"
+policy_scan: "{{ policy_name }}"   # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-crontab_hour: 2
+crontab_hour: 2   # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-crontab_minute: 0
+crontab_minute: 0   # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-crontab_weekdays: 0
+crontab_weekdays: 0  # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way
-foreman_operations_scap_client_secure_logging: true
+foreman_operations_scap_client_secure_logging: true   # noqa var-naming[no-role-prefix] - TODO : we should rework roles to use variable prefix, until scope is defined, silence is the way

linux/compliance_profiles.md

@@ -12,4 +12,3 @@ The following compliance profiles are supported by the [**Linux / Enforce Compli
 | DISA STIG | https://galaxy.ansible.com/RedHatOfficial/ansible-role-rhel8-stig |
 
 These roles are derived from the [Compliance as Code](https://github.com/ComplianceAsCode/content) project, which provides SCAP content used by the [OpenSCAP](https://www.open-scap.org/) `oscap` tool.
-

openshift/gitlab.yml

@@ -4,14 +4,14 @@
   gather_facts: false
 
   tasks:
-    - name: create cert-manager-operator namespace
+    - name: Create cert-manager-operator namespace
       redhat.openshift.k8s:
         name: cert-manager-operator
         api_version: v1
         kind: Namespace
         state: present
 
-    - name: create OperatorGroup object for cert-manager-operator
+    - name: Create OperatorGroup object for cert-manager-operator
       redhat.openshift.k8s:
         state: present
         definition:
@@ -24,7 +24,7 @@
             targetNamespaces:
               - cert-manager-operator
 
-    - name: create cert-manager-operator subscription
+    - name: Create cert-manager-operator subscription
       redhat.openshift.k8s:
         state: present
         definition:
@@ -42,14 +42,14 @@
             source: redhat-operators
             sourceNamespace: openshift-marketplace
 
-    - name: create gitlab-system namespace
+    - name: Create gitlab-system namespace
       redhat.openshift.k8s:
         name: gitlab-system
         api_version: v1
         kind: Namespace
         state: present
 
-    - name: create OperatorGroup object for gitlab-operator-kubernetes
+    - name: Create OperatorGroup object for gitlab-operator-kubernetes
       redhat.openshift.k8s:
         state: present
         definition:
@@ -62,7 +62,7 @@
             targetNamespaces:
               - gitlab-system
 
-    - name: create gitlab subscription
+    - name: Create gitlab subscription
       redhat.openshift.k8s:
         state: present
         definition:
@@ -80,8 +80,8 @@
             source: community-operators
             sourceNamespace: openshift-marketplace
 
-    - name: wait for gitlab operator to install
+    - name: Wait for gitlab operator to install
-      k8s_info:
+      kubernetes.core.k8s_info:
         api_version: apiextensions.k8s.io/v1
         kind: CustomResourceDefinition
         name: gitlabs.apps.gitlab.com
@@ -91,7 +91,7 @@
       delay: 30
 
     - name: Wait until gitlab-operator is up
-      k8s_info:
+      kubernetes.core.k8s_info:
         api_version: v1
         kind: Deployment
         name: gitlab-controller-manager

openshift/setup.yml

@@ -34,4 +34,3 @@ controller_templates:
     notification_templates_error: Telemetry
     credentials:
       - "OpenShift Credential"
-

windows/backup.yml

@@ -1,6 +1,6 @@
 ---
-- hosts: windows
+- name: Rollback playbook
-  name: Rollback playbook
+  hosts: windows
   tasks:
     - name: "Rollback this step"
       ansible.builtin.debug:

windows/create_ad_domain.yml

@@ -20,16 +20,16 @@
         - Wait for AD services again
 
     - name: Flush handlers
-      meta: flush_handlers
+      ansible.builtin.meta: flush_handlers
 
     - name: Create some groups
       community.windows.win_domain_group:
         name: "{{ item.name }}"
         scope: global
       loop:
-        - { name: "GroupA" }
+        - name: "GroupA"
-        - { name: "GroupB" }
+        - name: "GroupB"
-        - { name: "GroupC" }
+        - name: "GroupC"
       retries: 5
       delay: 10
 
@@ -40,9 +40,12 @@
         password: "{{ lookup('community.general.random_string', min_lower=1, min_upper=1, min_special=1, min_numeric=1) }}"
         update_password: on_create
       loop:
-        - { name: "UserA", groups: "GroupA" }
+        - name: "UserA"
-        - { name: "UserB", groups: "GroupB" }
+          groups: "GroupA"
-        - { name: "UserC", groups: "GroupC" }
+        - name: "UserB"
+          groups: "GroupB"
+        - name: "UserC"
+          groups: "GroupC"
       retries: 5
       delay: 10