This a bad commit message. NO idea.

roles/oatakan.ansible-role-ovirt/meta/.galaxy_install_info

@@ -1,2 +1,2 @@
-install_date: Wed Jun 30 01:12:51 2021
+install_date: Fri Oct 15 18:59:19 2021
 version: ''

roles/oatakan.ansible-role-ovirt/tasks/deprovision.yml

@@ -58,7 +58,7 @@
   until: disks_deletion.finished
   retries: "{{ instance_wait_retry_limit }}"
   delay: 10
-  with_items: "{{ delete_disks.results }}"
+  loop: "{{ delete_disks.results }}"
   when:
     - nodes is defined
     - delete_disks.results is defined

roles/oatakan.ansible-role-ovirt/tasks/provision.yml

@@ -48,7 +48,7 @@
   retries: "{{ instance_wait_retry_limit }}"
   delay: 10
   no_log: true
-  with_items: "{{ deploy.results }}"
+  loop: "{{ deploy.results }}"
   when:
     - nodes is defined
     - deploy.results is defined
@@ -85,7 +85,7 @@
   until: disks_creation.finished
   retries: "{{ instance_wait_retry_limit }}"
   delay: 10
-  with_items: "{{ create_disks.results }}"
+  loop: "{{ create_disks.results }}"
   when:
     - nodes is defined
     - create_disks.results is defined
@@ -110,7 +110,7 @@
       nic_name: "{{ item.networks[0].nic_name | default(item.networks[0].device_name) | default('eth0') }}"
       nic_on_boot: true
       host_name: "{{ item.name }}.{{ item.domain | default('') }}"
-      dns_servers: "{{ item.dns_servers|join(' ') | default([]) }}"
+      dns_servers: "{{ (item.dns_servers | default([])) | join(' ') }}"
       custom_script: "{{ item.custom_script | default('') }}"
       user_name: "{{ item.user_name | default('') }}"
       root_password: "{{ item.root_password | default('') }}"
@@ -144,7 +144,7 @@
 - name: combine deployment results
   set_fact:
     deploy_results: "{{ deploy_results|default([]) + [ item ] }}"
-  with_items: "{{ deploy_linux.results + deploy_windows.results }}"
+  loop: "{{ deploy_linux.results + deploy_windows.results }}"
   when:
     - nodes is defined
     - item.ansible_job_id is defined
@@ -156,7 +156,7 @@
   until: instances.finished
   retries: "{{ instance_wait_retry_limit }}"
   delay: 10
-  with_items: "{{ deploy_results }}"
+  loop: "{{ deploy_results }}"
   when:
     - nodes is defined
     - deploy_results is defined

roles/oatakan.ansible-role-ovirt/tasks/wait_for_ip.yml

@@ -1,31 +1,33 @@
 ---
 
-#- name: waiting for ip address to be assigned
-#  ovirt_nic_info:
-#    auth: "{{ ovirt_auth }}"
-#    vm: "{{ item.vm.name }}"
-#    name: nic1
-#  register: nics
-#  until:
-#    - nics.ovirt_nics | length > 0
-#    - nics.ovirt_nics[0].reported_devices | length > 0
-#    - nics.ovirt_nics[0].reported_devices[0].ips is defined
-#    - nics.ovirt_nics[0].reported_devices[0].ips | length > 0
-#    - nics.ovirt_nics[0].reported_devices[0].ips[0].address is defined
-#    - nics.ovirt_nics[0].reported_devices[0].ips[0].version == 'v4'
-#  retries: 300
-#  delay: 10
-#  with_items: "{{ instances.results }}"
-#  when:
-#    - nodes is defined
-#    - instances.results is defined
-#    - item.vm is defined
+- name: waiting for ip address to be assigned
+  ovirt_nic_info:
+    auth: "{{ ovirt_auth }}"
+    vm: "{{ item.vm.name }}"
+    name: nic1
+    fetch_nested: yes
+    nested_attributes:
+      - ips
+  register: nics
+  until:
+    - nics.ovirt_nics | length > 0
+    - nics.ovirt_nics[0].reported_devices | length > 0
+    - reported_ipv4_addresses | length
+  retries: 300
+  delay: 10
+  loop: "{{ instances.results }}"
+  when:
+    - nodes is defined
+    - instances.results is defined
+    - item.vm is defined
+  vars:
+    reported_ipv4_addresses: "{{ (nics.ovirt_nics[0].reported_devices | json_query('[*].ips[?version==`v4`].address') | flatten) | default([]) }}"
 
 - name: waiting for servers to come online on predefined ip
   wait_for:
     host: "{{ item.networks[0].ip }}"
     port: "{{ item.ansible_port | default(ansible_port) | default('22') }}"
-  with_items: "{{ nodes }}"
+  loop: "{{ nodes }}"
   when:
     - nodes is defined
     - item.networks is defined
@@ -33,9 +35,9 @@
 
 - name: waiting for servers to come online on dhcp ip
   wait_for:
-    host: "{{ (item.ovirt_nics[0].reported_devices[0].ips | json_query('[?version==`v4`].address'))[0] }}"
+    host: "{{ (item.ovirt_nics[0].reported_devices | json_query('[*].ips[?version==`v4`].address'))[0][0] | default('') }}"
     port: "{{ item.item.item.item.ansible_port | default(ansible_port) | default('22') }}"
-  with_items: "{{ nics.results }}"
+  loop: "{{ nics.results }}"
   when:
     - nodes is defined
     - nics.results is defined
@@ -55,15 +57,14 @@
   until:
     - nics.ovirt_nics | length > 0
     - nics.ovirt_nics[0].reported_devices | length > 0
-    - nics.ovirt_nics[0].reported_devices[0].ips | length > 0
-    - nics.ovirt_nics[0].reported_devices[0].ips[0].address is defined
-    - nics.ovirt_nics[0].reported_devices[0].ips[0].version == 'v4'
-    - nics.ovirt_nics[0].reported_devices[0].ips[0].address == item.networks[0].ip
+    - item.networks[0].ip in reported_ipv4_addresses
   retries: "{{ ip_wait_retry_limit }}"
   delay: 10
-  with_items: "{{ nodes }}"
+  loop: "{{ nodes }}"
   when:
     - wait_for_static_ip_assigned|bool
     - nodes is defined
     - item.networks | length > 0
-    - item.networks[0].ip is defined
+    - item.networks[0].ip is defined
+  vars:
+    reported_ipv4_addresses: "{{ (nics.ovirt_nics[0].reported_devices | json_query('[*].ips[?version==`v4`].address') | flatten) | default([]) }}"

roles/oatakan.ansible-role-ovirt/tasks/wait_for_ip_pre29.yml

@@ -1,31 +1,30 @@
 ---
 
-#- name: waiting for ip address to be assigned (<2.9)
-#  ovirt_nic_facts:
-#    auth: "{{ ovirt_auth }}"
-#    vm: "{{ item.vm.name }}"
-#    name: nic1
-#  register: nics
-#  until:
-#    - nics.ansible_facts.ovirt_nics | length > 0
-#    - nics.ansible_facts.ovirt_nics[0].reported_devices | length > 0
-#    - nics.ansible_facts.ovirt_nics[0].reported_devices[0].ips is defined
-#    - nics.ansible_facts.ovirt_nics[0].reported_devices[0].ips | length > 0
-#    - nics.ansible_facts.ovirt_nics[0].reported_devices[0].ips[0].address is defined
-#    - nics.ansible_facts.ovirt_nics[0].reported_devices[0].ips[0].version == 'v4'
-#  retries: 300
-#  delay: 10
-#  with_items: "{{ instances.results }}"
-#  when:
-#    - nodes is defined
-#    - instances.results is defined
-#    - item.vm is defined
+- name: waiting for ip address to be assigned (<2.9)
+  ovirt_nic_facts:
+    auth: "{{ ovirt_auth }}"
+    vm: "{{ item.vm.name }}"
+    name: nic1
+  register: nics
+  until:
+    - nics.ansible_facts.ovirt_nics | length > 0
+    - nics.ansible_facts.ovirt_nics[0].reported_devices | length > 0
+    - reported_ipv4_addresses | length
+  retries: 300
+  delay: 10
+  loop: "{{ instances.results }}"
+  when:
+    - nodes is defined
+    - instances.results is defined
+    - item.vm is defined
+  vars:
+    reported_ipv4_addresses: "{{ (nics.ovirt_nics[0].reported_devices | json_query('[*].ips[?version==`v4`].address') | flatten) | default([]) }}"
 
 - name: waiting for servers to come online on predefined ip
   wait_for:
     host: "{{ item.networks[0].ip }}"
     port: "{{ item.ansible_port | default(ansible_port) | default('22') }}"
-  with_items: "{{ nodes }}"
+  loop: "{{ nodes }}"
   when:
     - nodes is defined
     - item.networks is defined
@@ -35,7 +34,7 @@
   wait_for:
     host: "{{ (item.ansible_facts.ovirt_nics[0].reported_devices[0].ips | json_query('[?version==`v4`].address'))[0] }}"
     port: "{{ item.item.item.item.ansible_port | default(ansible_port) | default('22') }}"
-  with_items: "{{ nics.results }}"
+  loop: "{{ nics.results }}"
   when:
     - nodes is defined
     - nics.results is defined
@@ -55,15 +54,14 @@
   until:
     - nics.ansible_facts.ovirt_nics | length > 0
     - nics.ansible_facts.ovirt_nics[0].reported_devices | length > 0
-    - nics.ansible_facts.ovirt_nics[0].reported_devices[0].ips | length > 0
-    - nics.ansible_facts.ovirt_nics[0].reported_devices[0].ips[0].address is defined
-    - nics.ansible_facts.ovirt_nics[0].reported_devices[0].ips[0].version == 'v4'
-    - nics.ansible_facts.ovirt_nics[0].reported_devices[0].ips[0].address == item.networks[0].ip
+    - item.networks[0].ip in reported_ipv4_addresses
   retries: "{{ ip_wait_retry_limit }}"
   delay: 10
-  with_items: "{{ nodes }}"
+  loop: "{{ nodes }}"
   when:
     - wait_for_static_ip_assigned|bool
     - nodes is defined
     - item.networks | length > 0
-    - item.networks[0].ip is defined
+    - item.networks[0].ip is defined
+  vars:
+    reported_ipv4_addresses: "{{ (nics.ovirt_nics[0].reported_devices | json_query('[*].ips[?version==`v4`].address') | flatten) | default([]) }}"