oys/oysqn.app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
main
oysqn.app/docs/summaries/handoff-2026-04-22-schedule-admin-routing-fixes.md

8.9 KiB
Raw Permalink Blame History

Session Handoff: Schedule Interactivity, Admin Features, Routing Fix

Date: 2026-04-22 Session Duration: ~3 hours Session Focus: Fixed IonRouterOutlet route params bug; made schedule page fully interactive on desktop; added admin create/edit capabilities; added member names to schedule; documented Ionic+Nuxt watch-outs and new user stories. Context Usage at Handoff: ~85%

What Was Accomplished

  1. Diagnosed and fixed params: {} bug on edit page → root cause: Nuxt's auto-imported useRoute() always returns empty params inside IonRouterOutlet. Fix: import { useRoute, useRouter } from 'vue-router' directly. Documented in CLAUDE.md under "Ionic + Nuxt Watch-outs".

    • Output: app/pages/reservations/edit/[id].vue (import added)
    • Output: CLAUDE.md (new "Ionic + Nuxt Watch-outs" section under Routing)

  2. Made desktop schedule slots interactive → previously desktop grid had no click handlers. Added same tappable logic as mobile: available slots → create flow; own booked slots → action sheet with Edit/Cancel.

    • Output: app/pages/schedule.vue (template changes in desktop grid)

  3. Added confirmation dialog before cancelling from schedule → both mobile and desktop Cancel actions now show alertController confirmation before proceeding.

    • Output: app/pages/schedule.vue (confirmCancelSlot() wrapping cancelSlot())

  4. Added admin interactivity on schedule → admins can tap any booked slot (not just own). Action sheet header shows member name for admin context.

    • Output: app/pages/schedule.vue (authStore.isAdmin checks in tappable conditions and handleSlotClick)

  5. Added member names to schedule slots → put member_name into reservation_slots view via LEFT JOIN on members. security_invoker=false means the JOIN bypasses RLS — no separate query needed, no RLS block for non-admins.

    • Output: supabase/migrations/20260422000000_reservation_slots_add_user_id.sql
    • Output: app/types/supabase.ts (added user_id, member_name to reservation_slots Row)
    • Output: app/pages/schedule.vue (replaced getUserNameById calls with slot.memberName)

  6. Fixed slot display → desktop slots now show HH:MM-HH:MM on one line. All slots (available + booked, mobile + desktop) render a consistent 3-row structure (time, status, member) with min-height reserved for the member row so sizes are uniform.

    • Output: app/pages/schedule.vue (template restructure + CSS)

  7. Admin member selector on create reservation → when admin, step 2 of create flow shows a Member dropdown (defaults to "Self (admin)"). Selected member passed as target_user_id to edge function.

    • Output: app/pages/reservations/create.vue

  8. Admin member selector on edit reservation → when admin, edit page loads all members and shows a Member selector pre-populated from the reservation's user_id. Saved in update payload.

    • Output: app/pages/reservations/edit/[id].vue

  9. Edge function: admin target_user_id support → accepts optional target_user_id in body. If caller is admin and field is set, uses it as the reservation owner. Admins bypass cert check, weekly limit, and weekend limit. Historical booking guard simplified (was duplicating the admin fetch). Overlap constraint still applies to all.

    • Output: supabase/functions/create-reservation/index.ts

  10. Documented user stories → created docs/planning/user-stories.md with US-01–US-13 across four feature areas. Updated docs/summaries/00-project-brief.md with planned features table.

    • Output: docs/planning/user-stories.md (new file)
    • Output: docs/summaries/00-project-brief.md (planned features + open items)

Exact State of Work in Progress

  • All changes typecheck clean (yarn typecheck → no errors)
  • Migration 20260422000000 applied to local DB via supabase db reset
  • Migration NOT yet pushed to dev/prod Supabase — needs supabase db push or deploy pipeline
  • Edit page fix (import from vue-router) confirmed working conceptually; not browser-tested this session

Decisions Made This Session

  • Import useRoute/useRouter from vue-router directly, never use Nuxt auto-import BECAUSE Nuxt's auto-imported useRoute() always returns params: {} inside IonRouterOutlet — confirmed by official docs at ionic.nuxtjs.org/get-started/watch-outs and by console.log showing params: {} at runtime — STATUS: CONFIRMED. Apply to all future param-reading pages.

  • Put member_name in the view via JOIN rather than lazy-fetching via getUserNameById BECAUSE getUserNameById relies on a members query that is blocked by RLS for non-admin users (returns null → "Unknown"). security_invoker=false on the view makes the JOIN run as owner, bypassing RLS — STATUS: CONFIRMED.

  • Admins bypass all booking limits and cert checks in the edge function BECAUSE admin-created bookings are operational overrides, consistent with how admin/reservations.vue (direct insert) already worked — STATUS: CONFIRMED. Overlap constraint still applies to everyone.

  • Always render member name row in slot blocks (even if empty string) BECAUSE rendering it conditionally causes slots to have different heights — STATUS: CONFIRMED.

Key Numbers Generated or Discovered This Session

  • reservation_slots view now has 7 columns: id, boat_id, user_id, start_time, end_time, status, member_name
  • US-12, US-13 added (member profiles) — total user stories now: 13
  • Migration sequence: ...000002_prevent_past_reservation_updates.sql → ...20260422000000_reservation_slots_add_user_id.sql

Files Created or Modified

File Path Action Description
supabase/migrations/20260422000000_reservation_slots_add_user_id.sql Created Drops and recreates reservation_slots view with user_id and member_name (LEFT JOIN members)
app/types/supabase.ts Modified Added user_id: string and member_name: string | null to reservation_slots Row
app/pages/schedule.vue Modified Desktop interactivity; admin access; member names; confirmation dialog; slot display fix
app/pages/reservations/edit/[id].vue Modified Import useRoute/useRouter from vue-router; admin member selector
app/pages/reservations/create.vue Modified Admin member selector (step 2); passes target_user_id to edge function
supabase/functions/create-reservation/index.ts Modified target_user_id support; admin bypasses limits; deduped admin check
CLAUDE.md Modified Added "Ionic + Nuxt Watch-outs" section (6 rules from official docs)
docs/planning/user-stories.md Created US-01–US-13 across Open Reservations, Notifications, Check-out/in, Member Profiles
docs/summaries/00-project-brief.md Modified Added planned features table linking to user stories

What the NEXT Session Should Do

  1. First: Browser-test the edit page fix — navigate from home/schedule to an edit page and confirm reservation loads. Check console for any remaining params: {} warnings.
  2. Then: Push migration 20260422000000 to dev Supabase (supabase db push --linked or via deploy pipeline).
  3. Consider: Any other pages in the app that use useRoute() for params need the same import { useRoute } from 'vue-router' fix. Run a grep for auto-imported useRoute usage on param pages.
  4. Consider next feature: Open Reservations (US-01–US-07) or Member Profiles (US-12–US-13) — ask Patrick which to tackle.

Open Questions Requiring User Input

  • US-07: What constitutes a "non-member" on a reservation? (name-only entry, or guest account?) — impacts crew schema design
  • US-10: What fields are on the check-out/in forms? — impacts DB schema
  • US-13: Full list of member-controlled privacy fields (is phone in schema? any other fields?) — impacts members table migration
  • US-13: Privacy enforcement via RLS on members, or a separate member_profiles view? — impacts DB design
  • US-08: Discord webhook URL/channel — confirm stored in Vault at kv/oys/?

Assumptions That Need Validation

  • ASSUMED: import { useRoute } from 'vue-router' fixes params for ALL IonRouterOutlet param pages, not just the edit page — validate by testing at least one other param route if more are added.
  • ASSUMED: security_invoker=false on reservation_slots view is sufficient to expose member names to all authenticated users without violating privacy intent — validate with Patrick (member names may eventually be subject to US-13 privacy rules).

Files to Load Next Session

  • docs/summaries/handoff-2026-04-22-schedule-admin-routing-fixes.md — this file
  • docs/summaries/00-project-brief.md — project state and open items
  • docs/planning/user-stories.md — if working on any new feature
  • app/pages/schedule.vue — if continuing schedule work
  • CLAUDE.md — always (routing rules, data fetching pattern, Ionic watch-outs)